Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 01/25] tools/libxl: rename libxl__domain_suspend to libxl__domain_save

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote:
> The suspend/save terminology used by libxc is more consistent.
> "suspend" refers to quiescing the VM, so pausing qemu, making a
> remote_shutdown(SHUTDOWN_suspend) hypercall etc.
> "save" refers to the actions involved in actually shuffling the
> state of the VM, so xc_domain_save() etc.
> 
> libxl currently uses "suspend" to encapsulate both. The patch
> Rename libxl__domain_suspend() to libxl__domain_save() since it
> actually refers to shuffling the state of the VM.
> 
> This results in some strangeness in that some functions called *save*
> are now passed a struct called *suspend*, this is temporary and is all
> fixed up later by the refactoring of the suspend_state.
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> Some comments, commit messages:
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel