Re: [Xen-devel] [PATCH v8 11/11] (lib)xl: soft reset support

[Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>]

Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> writes:

> Vitaly Kuznetsov writes ("[PATCH v8 11/11] (lib)xl: soft reset support"):
>> Use existing create/restore path to perform 'soft reset' for HVM domains.
>> Tear everything down, e.g. destroy domain's device model, remove the domain
>> from xenstore, save toolstack record and start over.
>
> This patch has a number of long lines (eg in the documentation and
> comments) which make it hard to review.  Can you please keep it to 70
> columns, or 75 if you absolutely must ?

No problem, will do in v9. BTW, libxl/CODING_STYLE states that 'Lines
are limited to 75-80 characters'. I'd suggest we update that in case
70-75 is preferred.

>
> I'm not sure that this descriptiion:
>
>> +=item B<soft-reset>
>> +
>> +cleanup the domain without destroying it, restart the device
>> +model. This action is supported for HVM guests only.
>
> is really accurate from a user point of view.

Yea, I'm trying hard to avoid mentioning Linux and kexec while
describing soft reset. Will try to come up with something..


>
> Ian.

-- 
  Vitaly

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel