Re: [Xen-devel] [PATCH] sysctl: adjust XEN_SYSCTL_numainfo behavior

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Tue, 2015-07-14 at 10:52 +0100, Jan Beulich wrote:
> ... to match XEN_SYSCTL_cputopoinfo, allowing the caller to get what it
> needs (if e.g. it's after the data for just one specific node) with
> just one hypercall, without caring about the total number of nodes in
> the system.
> 
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

One question:

> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
>  
> @@ -335,7 +329,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xe
>          else
>              i = num_nodes;
>  
> -        if ( (!ret || (ret == -ENOBUFS)) && (ni->num_nodes != i) )
> +        if ( !ret && (ni->num_nodes != i) )
>          {
Can't we kill the parentheses around the second argument of the && ?

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel