Re: [Xen-devel] [PATCH] x86/HVM: drop now wrong ASSERT() from hvm_broadcast_ioreq()

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 14 July 2015 12:34
> To: xen-devel
> Cc: Andrew Cooper; Paul Durrant; Keir (Xen.org)
> Subject: [PATCH] x86/HVM: drop now wrong ASSERT() from
> hvm_broadcast_ioreq()
> 
> The function is now also being used for IOREQ_TYPE_TIMEOFFSET.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Ouch. Yes.

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> 
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2717,8 +2717,6 @@ unsigned int hvm_broadcast_ioreq(ioreq
>      struct hvm_ioreq_server *s;
>      unsigned int failed = 0;
> 
> -    ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
> -
>      list_for_each_entry ( s,
>                            &d->arch.hvm_domain.ioreq_server.list,
>                            list_entry )
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel