Re: [Xen-devel] [v7][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

> > +            {
> > +                printk(XENLOG_G_ERR VTDPREFIX
> > +                       " cannot assign %04x:%02x:%02x.%u"
> > +                       " with shared RMRR for Dom%d.\n",
> > +                       seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
> > +                       d->domain_id);
> > +                return -EPERM;
> > +            }
> > +        }
> Two if()-s like these should be folded into one.
>
> In your place I'd also consider also printing the RMRR base address
> for easier analysis of the issue.
I agree but I think the whole range info should be better,

" with shared RMRR [%"PRIx64",%"PRIx64"] for Dom%d.\n",

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel