Re: [Xen-devel] [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 4/9] libxl: dispose dominfo to avoid leaking 
resource"):
> On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote:
> > Add libxl_dominfo_dispose to one return path that doesn't have it.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> That return is a bit at odds with the generally correct error handling
> in that function, but this improves things at least a little and I can
> sort of see why this a slightly special case, so:

I think this should be done by changing `return' to `goto
out_success' or some such.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel