Re: [Xen-devel] [PATCH 1/9] libxl: fix libxl__abs_path

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> I rather dislike subjects of the form "fix $function", since it gives
> very little clue to someone reading the shortlog what is going on.

Yes.

> In this case I think "libxl: make libxl__abs_path correctly handle a
> NULL argument" would be an accurate description.

But: it is quite surprising that libxl__abs_path can be legally passed
a NULL for any of its parameters.

There are no call sites in libxl which can pass a NULL.

I think that if we are to retain this feature, it ought to be
documented, at least.

Maybe

  _hidden char *libxl__abs_path(libxl__gc *gc,
                                const char *s /* NULL OK */,
                                const char *path);

?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel