Re: [Xen-devel] [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [PATCH v3 19/28] tools/libxl: Convert a legacy 
stream if needed"):
> On 13/07/15 15:51, Ian Jackson wrote:
> > This would be more obviously correct (or at least more obviously never
> > leak a carefd) if you set v2_carefd to NULL here, and asserted its
> > NULLness at the end of check_all_finished just before making the
> > callback.
> 
> This argument applies to all the cleanup in this function, but we
> already assert that stream_done() is strictly executed once.
> 
> It would seem wrong to me to check just v2_carefd here, given all the
> other resources in need of cleanup.

Fair enought.

thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel