Re: [Xen-devel] [PATCH v3 17/28] tools/libxl: Infrastructure for reading a libxl migration v2 stream

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [PATCH v3 17/28] tools/libxl: Infrastructure for 
reading a libxl migration v2 stream"):
> On 13/07/15 14:42, Ian Campbell wrote:
> > On Mon, 2015-07-13 at 13:01 +0100, Andrew Cooper wrote:
> > Did you drop the assert prior to this on purpose?
> 
> I think it got lost while splitting the _init() out.  I shall re-introduce.

Please don't.  Or, if you do, please put in some comments in
libxl_internal.h about the public states of a
libxl__stream_read_state.

Earlier i wrote:

  I don't mind this at all but I think if you do this you should:
    * provide an _init method
    * document that _init must be called before start

and

   As far as I can tell, from the outside, this machinery has the usual
   Undefined/Idle/Active states.  [...]

It is usual for functions of this kind to take an Undefined struct and
make it Active.

See:
  - the comment in libxl_internal.h about `Event generation functions'
  - the following examples
      libxl__spawn_spawn      (accepts Undefined, this is documented)
      libxl__bootloader_run   (accepts Undefined, not documented)
      libxl__datacopier_start (accepts Undefined, not documented)
      libxl__openpty          (accepts Undefined; no init method)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel