Re: [Xen-devel] [PATCH OSSTEST v2 11/13] make-flight: debian hvm tests with libvirt

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jul 13, 2015 at 12:33:24PM +0100, Ian Campbell wrote:
> On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> > @@ -215,16 +217,17 @@ do_hvm_debian_test_one () {
> >    bios=$2
> >    xsm=$3
> >    stubdom=$4
> > +  toolstack=$5
> 
> Nit: For consistency with other similar function (job_create and filter
> in particular) I think toolstack should be inserted as $2, after
> $testname and before $bios.
> 
> Otherwise things look good to me. A diff of the runvars is always nice
> though.
> 

Changes to runvars in patch #0

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel