Re: [Xen-devel] [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote:
> Libvirt's configuration converter doesn't know how to deal with BIOS
> selection. The end result is it always use the default one (seabios).
> Stub out ovmf and rombios to avoid false positive results.

It's worth mentioning here whether or not we expect to currently see
such configurations in osstest today.

If we do expect to see them then it would be good to filter them in
make-flight to avoid wasting lots of test time.

> 
> This restriction will be removed once libvirt's converter knows how to
> deal with BIOS selection.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
>  ts-debian-hvm-install | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
> index f05b1a7..bd16506 100755
> --- a/ts-debian-hvm-install
> +++ b/ts-debian-hvm-install
> @@ -28,6 +28,13 @@ if (@ARGV && $ARGV[0] =~ m/^--stage(\d+)$/) { $stage=$1; 
> shift @ARGV; }
>  
>  defined($r{bios}) or die "Need to define which bios to use";
>  
> +# Libvirt doesn't know anything about bios. It will always use the
> +# default one (seabios). Stub out rombios and ovmf to avoid false
> +# positive results.
> +if ($r{bios} =~ m/ovmf|rombios/ && $r{toolstack} eq 'libvirt') {
> +    die "libvirt + $r{bios} is not supported yet.";
> +}
> +
>  our ($whhost,$gn) = @ARGV;
>  $whhost ||= 'host';
>  $gn ||= 'debianhvm';



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel