Re: [Xen-devel] [PATCH v2] x86/hvm: add support for broadcast of buffered ioreqs...

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 13 July 2015 09:44
> To: Paul Durrant
> Cc: Andrew Cooper; xen-devel@xxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v2] x86/hvm: add support for broadcast of buffered
> ioreqs...
> 
> >>> On 10.07.15 at 18:07, <paul.durrant@xxxxxxxxxx> wrote:
> > @@ -2710,17 +2711,21 @@ int hvm_send_assist_req(struct
> hvm_ioreq_server *s, ioreq_t *proto_p)
> >      return X86EMUL_UNHANDLEABLE;
> >  }
> >
> > -void hvm_broadcast_assist_req(ioreq_t *p)
> > +int hvm_broadcast_ioreq(ioreq_t *p, bool_t buffered)
> >  {
> >      struct domain *d = current->domain;
> >      struct hvm_ioreq_server *s;
> > +    unsigned int failed = 0;
> >
> >      ASSERT(p->type == IOREQ_TYPE_INVALIDATE);
> >
> >      list_for_each_entry ( s,
> >                            &d->arch.hvm_domain.ioreq_server.list,
> >                            list_entry )
> > -        (void) hvm_send_assist_req(s, p);
> > +        if ( hvm_send_ioreq(s, p, buffered) == X86EMUL_UNHANDLEABLE )
> > +            failed++;
> > +
> > +    return failed;
> 
> I'll try to remember fixing up the mismatch between function return
> type and return expression upon commit. Looks good beyond that.
> 

Ok. Thanks,

  Paul

> Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel