Re: [Xen-devel] [PATCH v5 2/4] x86/vm_event: toggle singlestep from vm_event response

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

On Fri, Jul 10, 2015 at 7:36 AM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:

On Thu, 2015-07-09 at 09:14 -0400, Tamas K Lengyel wrote:
>  xen/include/asm-arm/vm_event.h | 31 +++++++++++++++++++++++++++++++

Acked-by: Ian Campbell <Ian.campbell@xxxxxxxxxx>

> diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c
> new file mode 100644
> index 0000000..c390225
> --- /dev/null
> +++ b/xen/arch/x86/vm_event.c
> @@ -0,0 +1,41 @@
> +/*
> + * arch/x86/vm_event.c
> + *
> + * Architecture-specific vm_event handling routines
> + *
> + * Copyright (c) 2015 Tamas K Lengyel (tamas@xxxxxxxxxxxxx)
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public
> + * License v2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public
> + * License along with this program; if not, write to the
> + * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> + * Boston, MA 021110-1307, USA.

FYI I think current best practice is to omit the paragraph with the
address.

The more so because this is not AIUI their current address...

This shouldn't block acceptance of the patch though IMHO

Good to know. I just copy pasted it from another file (hvm.c if I recall correctly).

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel