[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v3 03/15] Add cmpxchg16b support for x86-64



>>> On 24.06.15 at 07:18, <feng.wu@xxxxxxxxx> wrote:
> --- a/xen/include/xen/types.h
> +++ b/xen/include/xen/types.h
> @@ -47,6 +47,11 @@ typedef         __u64           uint64_t;
>  typedef         __u64           u_int64_t;
>  typedef         __s64           int64_t;
>  
> +typedef struct {
> +        uint64_t low;
> +        uint64_t high;
> +} uint128_t;

This violates the C standard; if you did this in an x86-specific file
(or conditional upon BITS_PER_LONG >= 64) I can't see why you
couldn't use gcc's __uint128_t built-in type (available on arches
with host word width >= 64 bits).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.