Re: [Xen-devel] [PATCH 5/9] libxl: event tests: Contemplate separate tests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 09, 2015 at 06:47:53PM +0100, Ian Jackson wrote:
> Split LIBXL_TESTS into two variables, each of which gets all of
> LIBXL_TESTS, so that we can have tests which do use generic test
> helper inside functions, rather than test-specific ones.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/Makefile |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 44a4da7..512b0e1 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -100,6 +100,9 @@ LIBXL_OBJS += libxl_genid.o
>  LIBXL_OBJS += _libxl_types.o libxl_flask.o _libxl_types_internal.o
>  
>  LIBXL_TESTS += timedereg
> +LIBXL_TESTS_PROGS = $(LIBXL_TESTS)
> +LIBXL_TESTS_INSIDE = $(LIBXL_TESTS)
> +
>  # Each entry FOO in LIBXL_TESTS has two main .c files:
>  #   libxl_test_FOO.c  "inside libxl" code to support the test case
>  #   test_FOO.c        "outside libxl" code to exercise the test case
> @@ -117,9 +120,9 @@ LIBXL_TESTS += timedereg
>  # loaded, or rename it to libxenlight.so so it is the target of the
>  # appropriate symlinks.
>  
> -LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS),libxl_test_$t.o)
> -TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS),test_$t.o) test_common.o
> -TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
> +LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.o)
> +TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o
> +TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t)
>  
>  $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include 
> $(XEN_ROOT)/tools/config.h
>  
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel