Re: [Xen-devel] [PATCH v7 07/15] x86/hvm: unify stdvga mmio intercept with standard mmio intercept

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 09 July 2015 17:22
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxx; Keir (Xen.org)
> Subject: RE: [PATCH v7 07/15] x86/hvm: unify stdvga mmio intercept with
> standard mmio intercept
> 
> >>> On 09.07.15 at 18:12, <Paul.Durrant@xxxxxxxxxx> wrote:
> >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> >> Sent: 09 July 2015 16:33
> >> >>> On 09.07.15 at 15:10, <paul.durrant@xxxxxxxxxx> wrote:
> >> > @@ -424,8 +426,22 @@ static void stdvga_mem_writeb(uint64_t addr,
> >> uint32_t val)
> >> >      }
> >> >  }
> >> >
> >> > -static void stdvga_mem_write(uint64_t addr, uint64_t data, uint64_t
> size)
> >> > +static int stdvga_mem_write(const struct hvm_io_handler *handler,
> >> > +                            uint64_t addr, uint32_t size,
> >> > +                            uint64_t data)
> >> >  {
> >> > +    struct hvm_hw_stdvga *s = &current->domain-
> >arch.hvm_domain.stdvga;
> >> > +    ioreq_t p = { .type = IOREQ_TYPE_COPY,
> >> > +                  .addr = addr,
> >> > +                  .size = size,
> >> > +                  .count = 1,
> >> > +                  .dir = IOREQ_WRITE,
> >> > +                  .data = data,
> >> > +                };
> >>
> >> Indentation (still - I know I pointed this out on v6, just perhaps at
> >> another example). See e.g. the context of the earlier change to the
> >> beginning of hvm_mmio_internal() in this patch for how this should
> >> look like.
> >
> > It has to be something my emacs is doing then; I can't see any brokenness.
> 
> Indentation simply is too deep. See the good example I pointed
> you at.
> 

Yes, I'll look... and maybe see what it looks like with vi too.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel