Re: [Xen-devel] [PATCH v3 00/12] Alternate p2m: support multiple copies of host p2m

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.07.15 at 13:49, <wei.liu2@xxxxxxxxxx> wrote:
> As far as I can tell, there are several issues here with regard to this
> patch series on hypervisor side:
> 
> 1. Patch #1 is neither acked nor reviewed.

The patch is obvious and straightforward - the only reason I didn't
commit it yet is that it would be dead code right now.

> 3. Patch #7 has issue with regard to instruction emulator.

Those would seem to be easily fixed.

> 4. Patch #8 in this version (#7 in previous version, v2) is reviewed,
>    but I'm not sure if the concern raised in v2 went away. Judging
>    from the date of v3 submission and date of issue raised on v2, the
>    issue is still there.

No, the concern did not go away, but George actually had provided
a patch to address the concern.

> 5. Patch #11 is not acked, and because it's ABI matter we need to be
>    very careful about it.

Indeed. But directions were given, so it should be mostly a
mechanical thing.

> Question for hypervisor maintainers, how much risk do you think this
> series impose?  If this feature is off, is the code path more or less
> the same of before?

It looks like it mostly is, so I don't view the risk as too high.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel