[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 3/3] x86/monitor: don't use hvm_funcs directly
- To: "Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>
- From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
- Date: Thu, 9 Jul 2015 15:55:18 +0300
- Cc: kevin.tian@xxxxxxxxx, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, eddie.dong@xxxxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, keir@xxxxxxx
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Thu, 09 Jul 2015 12:54:45 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=neFkCc0HzhLZPLGu3P10E9WxBceJGrVdPKa0IDHjkI6Ioc7kT25FssYzaSD334Zab2g9l0pF9YYgqI0I2YyWmyouAb6kCFpVHNS6XmgDg9LqHsmhKTHPtlSY6t8RUx8Tq5wZGvEhVYLiWF2/uptOHKTQaxKdfnewU5iOMgRCOoGfUuRjXHvfX38/Ee7GfwhvxklrI6McZSVwFYs1piXolNgOWZXaxTx2VZ5WB4rYE2AuUX9zsL92k1eG1tzO/A1ny35x9LFXUBRL4xBqyYBhAXl8yh60/0KJRDz6U9pITbwMPfBIJoWV9AdUaCiqSNNESYniVOVZQGoEk577ymDTIA==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 07/09/2015 03:52 PM, Lengyel, Tamas wrote:
> I don't feel very strongly about it, so if you really prefer you can
> keep the code as it is, however this looks somewhat counterintuitive to
> me, especially when you compare the new condition to the old one,
> because
> ...
>
>
> Yea, this patch is not critical. Jan just requested to use a wrapper for
> hvm_funcs in the other patch so I figured I might as well fix it
> everywhere in our code. It's pretty minor stuff.
Well, I think that the patch is a good idea, I was just talking about
changing the function to return a bool_t. Sorry for not being clearer.
Cheers,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|