Re: [Xen-devel] [PATCH OSSTEST v7 1/2] cr-publish-flight-logs: support publishing files from $HOME/public_html

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v7 1/2] cr-publish-flight-logs: support 
publishing files from $HOME/public_html"):
> Any arguments given after the flight are assumed to be files or
> directories relative to $HOME/public_html which should be published to
> $c{Publish} at the same relative path.
> 
> Removing the requirement that a flight be provided, by accepting '',
> allows this to be used even in contexts which have no flight.
> 
> The results subtree is always published if $c{ResultsPublish} is set,
> since it doesn't depend on any particular flight.

Uh.  Looking at this, I hadn't spotted that in your other patch you
generate the output in ~/public_html.  Shouldn't it be in results/
(which is nowadays a general place for publicly visible output) ?

At the very least, if you do mean ~/public_html, you should be using
WebspaceFile.

Also:

> -sub copydir ($$) {
> +sub copylogs ($$) {

Why did you rename this function ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel