Re: [Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>]

----- JBeulich@xxxxxxxx wrote:

> >>> On 09.07.15 at 13:13, <elena.ufimtseva@xxxxxxxxxx> wrote:
> > On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
> >> >>> On 08.07.15 at 19:27, <konrad.wilk@xxxxxxxxxx> wrote:
> >> > On Tue, Jun 30, 2015 at 07:33:59PM -0400,
> elena.ufimtseva@xxxxxxxxxx wrote:
> >> >> From: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
> >> >> 
> >> > 
> >> > You usually say why you need this patch. Something as simple as:
> >> > 
> >> > "In preperation for patch XXXX which will use it" is OK.
> >> 
> >> Or, even better, add such macros when the first user appears. Iirc
> >> I said so before...
> >>
> > Yes, I realized this late. Will move over in the next version if
> needed. 
> 
> Don't you need to rebase on top of v6 of "dmar: device scope mem
> leak fix" anyway? Or does the series not conflict with those changes?

You are right, it needs to be rebased. I can post later rebased on memory leak 
fix version, if you thin its a way to go.
> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel