Re: [Xen-devel] [PATCH v6 04/16] x86/hvm: restrict port numbers to uint16_t and sizes to unsigned int

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 08 July 2015 16:57
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v6 04/16] x86/hvm: restrict port numbers to uint16_t
> and sizes to unsigned int
> 
> >>> On 03.07.15 at 18:25, <paul.durrant@xxxxxxxxxx> wrote:
> > Building on the previous patch, this patch restricts portio port numbers
> > to uint16_t in registration/relocate calls and portio_action_t. It also
> > changes portio sizes to unsigned int which then allows the io_handler
> > size field to reduce to an unsigned int.
> 
> Changing size's type is fine; changing port numbers to uint16_t will -
> afaict - generate worse code, and hence doesn't seem warranted.
> I wouldn't mind changing from uint32_t to unsigned int though.
> 

<sigh> More yak-shaving then.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel