Re: [Xen-devel] [PATCH 2/4] xen: sched: factor code that moves a vcpu to a new pcpu in a function

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2015-07-08 at 15:56 +0100, George Dunlap wrote:
> On Fri, Jul 3, 2015 at 4:49 PM, Dario Faggioli
> <dario.faggioli@xxxxxxxxxx> wrote:
> > No functional change intended.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
Thanks.

> With one nit...

> > diff --git a/xen/common/schedule.c b/xen/common/schedule.c
> > index 26e8430..e83c666 100644
> > --- a/xen/common/schedule.c
> > +++ b/xen/common/schedule.c
> > @@ -451,6 +451,34 @@ void vcpu_unblock(struct vcpu *v)
> >      vcpu_wake(v);
> >  }
> >
> > +/*
> > + * Do the actual movemet of a vcpu from old to new CPU. Locks for *both*
> 
> "movement"  (missing an 'n')
> 
Yeah, well, what I was missing was 'set spell' in .vimrc. Done now,
hopefully, this would help limiting things like this! :-/

Anyway, I'll resend and take care of this.

Thanks again,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel