Re: [Xen-devel] [PATCH v3 for Xen 4.6 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Tue, Jul 7, 2015 at 11:23 AM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to 
>> support
>> per-VCPU settings.
>>

>>
>> +/* Per-VCPU parameters*/
>> +#define LIBXL_DOMAIN_SCHED_PARAM_VCPU_INDEX_DEFAULT -1
>> +
>>  int libxl_domain_sched_params_get(libxl_ctx *ctx, uint32_t domid,
>>                                    libxl_domain_sched_params *params);
>>  int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid,
>>                                    const libxl_domain_sched_params *params);
>> +int libxl_vcpu_sched_params_get(libxl_ctx *ctx, uint32_t domid,
>> +                                  libxl_vcpu_sched_params *params);
>> +int libxl_vcpu_sched_params_set(libxl_ctx *ctx, uint32_t domid,
>> +                                  const libxl_vcpu_sched_params *params);
>>
> Didn't we say that we wanted the fact that now, at least for RTDS,
> libxl_domain_sched_params_*() deals with default parameters to be
> documented in a comment somewhere? Have I missed it?

I'll implement it in the next version.

Do both get/set deal with default parameters? I can easily implement
it in hypervisor, because default parameters
(RTDS_DEFAULT_PERIOD/BUDGET) are just defined there. But for libxl,
how do I deal with it without knowing the default values?
>
> I appreciate that this is happening in lower levels, and that libxl is
> just reporting it, but, still, it is something that I would like to find
> in the headers of the library, in order to be able to tell the
> differences between  libxl_vcpu_sched_params_* and
> libxl_domain_sched_params_* ... Ian?


>
> Regards,
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel