Re: [Xen-devel] [PATCH v3 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Tue, Jul 7, 2015 at 10:16 AM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>
>> [Usage]
>> With this patchset in use, xl sched-rtds tool can:
>>
>> 1) show the budget and period of each VCPU of each domain, by using "xl 
>> sched-rtds -v all" command. An example would be like:
>>
> Ok. Thanks for this summary, and for including the actual output.
>
>> # xl sched-rtds -v all
>> Cpupool Pool-0: sched=RTDS
>> Name                                ID VCPU    Period    Budget
>> Domain-0                             0    0     10000      4000
>> vm1                                  1    0       300       150
>> vm1                                  1    1       400       200
>> vm1                                  1    2     10000      4000
>> vm1                                  1    3      1000       500
>> vm2                                  2    0     10000      4000
>> vm2                                  2    1     10000      4000
>>
> Right. What happens with just `xl sched-rtds'?
>>
>> 2) show the budget and period of each VCPU of a specific domain, by using,
>> e.g., "xl sched-rtds -d vm1 -v all" command. The output would be like:
>>
>> # xl sched-rtds -d vm1 -v all
>> Name                                ID VCPU    Period    Budget
>> vm1                                  1    0       300       150
>> vm1                                  1    1       400       200
>> vm1                                  1    2     10000      4000
>> vm1                                  1    3      1000       500
>>
> Same as above: what happens with just `xl sched-rtds -d vm1'?

 'xl sched-rtds ( -d vm1)' will return an error message. As you
suggested, I'll make it return per-domain default parameters in the
next version.
>
>> To show a subset of the parameters of the VCPUs of a specific domain, please 
>> use, e.g.,"xl sched-rtds -d vm1 -v 0 -v 3" command. The output would be:
>>
>> # xl sched-rtds -d vm1 -v 0 -v 3
>> Name                                ID VCPU    Period    Budget
>> vm1                                  1    0       300       150
>> vm1                                  1    3      1000       500
>>
>>
>> 3) Users can set the budget and period of multiple VCPUs of a specific domain
>> with only one command, e.g., "xl sched-rtds -d vm1 -v 0 -p 100 -b 50 -v 3 -p 
>> 300 -b 150".
>>
>> Users can set all VCPUs with the same parameters, by one command.
>> e.g., "xl sched-rtds -d vm1 -v all -p 500 -b 250".
>>
> Forgive me for asking, as I really think it's rather obvious you've done
> this, but I guess you've stress tested this by feeding the various
> switches with arbitrary bad arguments, and checked that things do not
> explode?
>
> If you've done it, then fine. It's not necessary that you include (all)
> the results of that too in here... I just wanted do double check because
> this is certainly not the easiest piece of interface we have in xl.

Yes, I've done stress test.

>
> Anyway, I'll give it a go too.
>
> Regards,
> Dario
>
>>
>> ---
>> CC: <dario.faggioli@xxxxxxxxxx>
>> CC: <george.dunlap@xxxxxxxxxxxxx>
>> CC: <dgolomb@xxxxxxxxxxxxxx>
>> CC: <mengxu@xxxxxxxxxxxxx>
>> CC: <jbeulich@xxxxxxxx>
>> CC: <wei.liu2@xxxxxxxxxx>
>> CC: <lichong659@xxxxxxxxx>
>> CC: <ian.jackson@xxxxxxxxxxxxx>
>> CC: <ian.campbell@xxxxxxxxxxxxx>
>>
>>
>> Chong Li (4):
>>   xen: enable per-VCPU parameter settings for RTDS scheduler
>>   libxc: enable per-VCPU parameter settings for RTDS scheduler
>>   libxl: enable per-VCPU parameter settings for RTDS scheduler
>>   xl: enable per-VCPU parameter settings for RTDS scheduler
>>
>>  docs/man/xl.pod.1             |   4 +
>>  tools/libxc/include/xenctrl.h |   9 ++
>>  tools/libxc/xc_csched.c       |   4 +-
>>  tools/libxc/xc_csched2.c      |   4 +-
>>  tools/libxc/xc_rt.c           |  64 +++++++++-
>>  tools/libxc/xc_sedf.c         |   4 +-
>>  tools/libxl/libxl.c           | 209 +++++++++++++++++++++++++++----
>>  tools/libxl/libxl.h           |  17 +++
>>  tools/libxl/libxl_types.idl   |  16 +++
>>  tools/libxl/xl_cmdimpl.c      | 284 
>> +++++++++++++++++++++++++++++++++++-------
>>  tools/libxl/xl_cmdtable.c     |  10 +-
>>  xen/common/Makefile           |   1 -
>>  xen/common/domctl.c           |   3 +
>>  xen/common/sched_credit.c     |  14 +--
>>  xen/common/sched_credit2.c    |   6 +-
>>  xen/common/sched_rt.c         |  80 +++++++++++-
>>  xen/common/schedule.c         |   5 +-
>>  xen/include/public/domctl.h   |  64 +++++++---
>>  18 files changed, 680 insertions(+), 118 deletions(-)
>>
>
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel