Re: [Xen-devel] [PATCH V3 1/3] xen/mem_access: Support for memory-content hiding

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

On Tue, Jul 7, 2015 at 4:10 AM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> wrote:

On 07/06/2015 09:30 PM, Lengyel, Tamas wrote:
>     If you'd prefer that I do some ground work for the future (i.e. rename
>     MEM_ACCESS constants, etc.), please let me know.
>
>
> Yeap, that sounds reasonable to me.

Any objections to this renaming?

151 #define MEM_ACCESS_EMULATE_NOWRITE       (1 << 7)
152 /*
153  * Data is being sent back to the hypervisor in the event response,
to be
154  * returned by the read function when emulating an instruction.
155  * This flag is only useful when combined with MEM_ACCESS_EMULATE or
156  * MEM_ACCESS_EMULATE_NOWRITE.
157  * The flag has been defined here because it is used with mem_access
158  * events, and so should not accidentaly overwrite one of the above.
159  */
160 #define VM_EVENT_FLAG_SET_EMUL_READ_DATA (1 << 8)

Are there any other small changes you'd like to see in this patch?

That should suffice - with the flag being move to the VM_EVENT_FLAG list and the bitshift adjusted accordingly.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel