Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

On Tue, Jul 7, 2015 at 5:27 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 30.06.15 at 16:11, <tlengyel@xxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op)
>      return rc;
>  }
>
> +void hvm_toggle_singlestep(struct vcpu *v)
> +{
> +    ASSERT(atomic_read(&v->pause_count));
> +
> +    /* This feature is only available on Intel CPUs. */
> +    if ( !cpu_has_monitor_trap_flag )

I'd be okay with this if the get-capabilities patch then changed it
to use hvm_is_singlestep_supported(). And the two patches
conflict with one another anyway, so should be put together in
a series with this one being 2nd.

Jan

Makes sense, will do so.

Thanks,

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel