Re: [Xen-devel] [PATCH v3 11/32] xen/x86: add bitmap of enabled emulated devices

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.07.15 at 16:10, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 03/07/15 12:34, Roger Pau Monne wrote:
>> @@ -550,6 +551,20 @@ int arch_domain_create(struct domain *d, unsigned int 
>> domcr_flags,
>>                 d->domain_id);
>>      }
>>  
>> +    if ( is_hvm_domain(d) )
>> +    {
>> +        emulation_mask = (EMU_LAPIC | EMU_HPET | EMU_PMTIMER | EMU_RTC |
>> +                          EMU_IOAPIC | EMU_PIC | EMU_PMU | EMU_VGA | 
>> EMU_IOMMU);
>> +        if ( (config->emulation_flags & emulation_mask) != emulation_mask )
>> +        {
>> +            printk(XENLOG_G_ERR "Xen does not allow HVM creation with the "
>> +                   "current selection of emulators: 0x%x.\n",
>> +                   config->emulation_flags);
> 
> Please put "d%d" in the error message to identify which domain has the
> bad configuration.

Plus please use %#x instead of 0x%x.

>> +            return -EPERM;
> 
> EPERM feels wrong here.  It is not a lack of permissions causing the
> issue.  EINVAL/EOPNOTSUPP perhaps?

Indeed, -EOPNOTSUPP.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel