Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 07/07/2015 09:20 AM, Jan Beulich wrote:
>>>> On 06.07.15 at 19:03, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> I don't mind just having the comment for now, so for what it's worth I
>> stand by my ack.
>>
>> Having said that (and with the understading that it is beyond the scope
>> of this patch), a way to validate things like these is a good idea. I
>> wonder if, in a future patch, we could not have ./configure detect these
>> things and simply disable the relevant VM_EVENT_FLAG constants with
>> #if(n)defs, for example. That way, you wouldn't be able to compile code
>> that wouldn't work silently on platforms where that is the case.
> 
> I don't follow: Are you saying this assuming that everyone would
> configure and build on the target system? I.e. are you leaving
> distros completely out of consideration?

I was, as also pointed out by Andrew. Tamas has, in the meantime,
submitted a patch doing this the right way (adding the ability to query
hypervisor capabilities).


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel