Re: [Xen-devel] [PATCH v6 6/6] xen: arm: consolidate mmio and irq mapping to dom0

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 03/07/15 16:56, Ian Campbell wrote:
> The code in the callbacks for dt_for_each_irq_map and
> dt_for_each_range is very similar to the code in handle_device for
> each non-pci device.
> 
> In fact the only major difference is that the irq callback needs to
> call irq_set_spi_type in the PCI case. Refactor into a
> map_dt_irq_to_domain callback which does the irq_set_spi_type and then
> calls map_irq_to_domain which is also used from handle_device.
> 
> For mmio map_range_to_domain can already be used directly from
> handle_device too.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel