Re: [Xen-devel] [PATCH v2 16/41] acpi : Introduce acpi_parse_entries

[Parth Dixit <parth.dixit@xxxxxxxxxx>]

+shannon

On 21 May 2015 at 14:50, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 21.05.15 at 11:14, <parth.dixit@xxxxxxxxxx> wrote:
>> On 20 May 2015 at 21:43, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>>> >>> On 17.05.15 at 22:03, <parth.dixit@xxxxxxxxxx> wrote:
>>> > add new function acpi_parse_entries which takes
>>> > acpi table as argument. This will avoid fetching table
>>> > everytime in acpi_table_parse_entries.
>>>
>>> This explanation doesn't make a lot of sense to me - I don't see you
>>> save anything. Am I missing anything? Are you intending to use the
>>> new function separately? Also, please don't break indentation like
>>>
>> yes, i am fetching the table once and parsing it with this function in
>> acpi_gicv2_init function in the patch given below
>> http://lists.xen.org/archives/html/xen-devel/2015-05/msg02208.html
>
> So - just like elsewhere - please correct the patch description then.
>
> Jan
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel