Re: [Xen-devel] [PATCH v2 11/41] arm/acpi : add GTDT support updated by ACPI 5.1

[Parth Dixit <parth.dixit@xxxxxxxxxx>]

+shannon

On 24 May 2015 at 11:36, Parth Dixit <parth.dixit@xxxxxxxxxx> wrote:
>
>
> On 18 May 2015 at 20:41, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>>
>> Hi Parth,
>>
>> On 17/05/15 21:03, Parth Dixit wrote:
>> > With ACPI 5.0, we got per-processor timer support in GTDT,
>> > and ACPI 5.1 introduced the support for platform (memory-mapped)
>> > timers: GT Block and SBSA watchdog timer, add the code needed
>> > for the spec change.
>> >
>> > Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>> > Signed-off-by: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
>> > Signed-off-by: Parth Dixit <parth.dixit@xxxxxxxxxx>
>> > ---
>> >  xen/include/acpi/actbl3.h  | 92
>> > +++++++++++++++++++++++++++++++++++++++-------
>> >  xen/include/asm-arm/acpi.h |  2 +
>> >  2 files changed, 80 insertions(+), 14 deletions(-)
>> >
>> > diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h
>> > index 8c61b5f..7664f9d 100644
>> > --- a/xen/include/acpi/actbl3.h
>> > +++ b/xen/include/acpi/actbl3.h
>> > @@ -241,33 +241,97 @@ struct acpi_s3pt_suspend {
>> >
>> >
>> > /*******************************************************************************
>> >   *
>> > - * GTDT - Generic Timer Description Table (ACPI 5.0)
>> > + * GTDT - Generic Timer Description Table (ACPI 5.1)
>> >   *        Version 1
>> >   *
>> >
>> > ******************************************************************************/
>> >
>> >  struct acpi_table_gtdt {
>> >       struct acpi_table_header header;        /* Common ACPI table
>> > header */
>> > -     u64 address;
>> > -     u32 flags;
>> > -     u32 secure_pl1_interrupt;
>> > -     u32 secure_pl1_flags;
>> > -     u32 non_secure_pl1_interrupt;
>> > -     u32 non_secure_pl1_flags;
>> > +     u64 cnt_control_base_address;
>>
>> This patch is out-of-sync compare to the Linux one (naming different,
>> comment...). Can you update it?
>>
> sure, i'll take care in next patchset.
>>
>> Regards,
>>
>> --
>> Julien Grall
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel