Re: [Xen-devel] [PATCH 7/7] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 7/7] libxc: Prevent NULL pointer 
dereference in stdiostream_vmessage()"):
> On Fri, 2015-07-03 at 16:29 +0100, Ian Jackson wrote:
> > I think it would be best, in this error case, to explicitly note that
> > date/time conversion failed, by printing (say) "[localtime_r failed:
> > <errno>]".  Sadly that will involve calling strerror and doing
> > something sensible if strerror fails, too.
> 
> Perhaps a smaller yakk would be to just include the numeric errno? For
> such a rare error case having to worry about two layers of nested error
> handling seems annoying...

That would satisfy me.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel