[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/7] libxl: get rid of the SEDF scheduler
On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote: > On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote: > > > @@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx, > > uint32_t domid, > > > > switch (sched) { > > case LIBXL_SCHEDULER_SEDF: > > - ret=sched_sedf_domain_set(gc, domid, scinfo); > > + LOG(ERROR, "SEDF scheduler no longer available"); > > + ret=ERROR_INVAL; > > Should we have a specific error code for removed functionality? > Good point: shall I introduce it? If yes, how should it be called? ERROR_REMOVED ERROR_DEPRECATED ERROR_GONE I think I'd go for _REMOVED, as deprecated suggests (to me at least) that it's still there but nshould not be used. Any other ideas? Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |