Re: [Xen-devel] [PATCH v2 4/7] xen: get rid of the SEDF scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2015-07-03 at 11:30 +0100, Andrew Cooper wrote:
> On 03/07/15 11:25, Dario Faggioli wrote:
> > more specifically, of all the symbols and references
> > to it.
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >
> > Changes from v1:
> >  - added markers for removed #defines, to help keep bits
> >    of the history, and reduce the likelyhood of accidental
> >    reuse, as requested during review.
> > ---
> >  docs/misc/xen-command-line.markdown |    2 +-
> >  xen/common/Makefile                 |    1 -
> >  xen/common/schedule.c               |    1 -
> >  xen/include/public/domctl.h         |    9 +--------
> >  xen/include/public/trace.h          |    2 +-
> >  xen/include/xen/sched-if.h          |    1 -
> >  6 files changed, 3 insertions(+), 13 deletions(-)
> 
> Perhaps you wish to include git rm xen/common/sched_sedf.c ?
> 
It's patch 5... I did it separately, with the aim of making this very
one easier to review.

It's sort-of like separating code-motion and actual changes. I
appreciate that in this case the 'code-motion' is the removal of a file,
which would have been pretty easy to spot even if folded in here, but
yet I saw some value of doing things like this.

Anyway...

> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
...Thanks :-)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel