Re: [Xen-devel] [PATCH v2] libxl: Make local_initiate_attach more rational

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

El 02/07/15 a les 19.42, George Dunlap ha escrit:
> There are a lot of paths through
> libxl__device_disk_local_initiate_attach(), but they all really boil
> down to one thing: Can we just access the file directly, or do we need
> to attach it?
> 
> The requirements for direct access are fairly simple:
> * Is this local (as opposed to a driver domain)?
> * Is this a raw format (as opposed to cooked)?
> * Does this have no scripts associated with it?
> 
> If it meets all those requirements, we can access it directly;
> otherwise we need to attach it.
> 
> This fixes a bug where bootloader execution fails for disks with
> hotplug scripts.
> 
> This should fix a theoretical bug when using a qdisk backend in a
> driver domain. (Not tested.)
> 
> Based on a patch by Roger Pau Monne <roger.pau@xxxxxxxxxx>.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

LGTM

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel