Re: [Xen-devel] [PATCH v5 04/16] x86/hvm: restrict port numbers to uint16_t and sizes to unsigned int

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: 02 July 2015 16:55
> To: Paul Durrant; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Keir (Xen.org); Jan Beulich
> Subject: Re: [PATCH v5 04/16] x86/hvm: restrict port numbers to uint16_t
> and sizes to unsigned int
> 
> On 30/06/15 14:05, Paul Durrant wrote:
> > diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-
> x86/hvm/io.h
> > index d1d79dc..1ed0c13 100644
> > --- a/xen/include/asm-x86/hvm/io.h
> > +++ b/xen/include/asm-x86/hvm/io.h
> > @@ -41,12 +41,12 @@ typedef int (*hvm_mmio_write_t)(struct vcpu *v,
> >  typedef int (*hvm_mmio_check_t)(struct vcpu *v, unsigned long addr);
> >
> >  typedef int (*portio_action_t)(
> > -    int dir, uint32_t port, uint32_t bytes, uint32_t *val);
> > +    int dir, uint16_t port, unsigned int bytes, uint32_t *val);
> >  typedef int (*mmio_action_t)(ioreq_t *);
> >  struct io_handler {
> >      int                 type;
> >      unsigned long       addr;
> > -    unsigned long       size;
> > +    unsigned int        size;
> 
> You want to reorder size above addr to fill a 4 byte hole and avoid
> introducing a second.
> 

Sure.

  Paul

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel