Re: [Xen-devel] [PATCH v4] dmar: device scope mem leak fix

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/07/15 00:20, elena.ufimtseva@xxxxxxxxxx wrote:
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -81,6 +81,13 @@ static int __init acpi_register_rmrr_unit(struct 
> acpi_rmrr_unit *rmrr)
>      return 0;
>  }
>  
> +static void scope_devices_free(struct dmar_scope *scope)
> +{
> +    if ( scope )
> +        scope->devices_cnt = 0;
> +    xfree(scope->devices);

This is very liable to suffer a NULL pointer dereference.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel