[Xen-devel] [PATCH] tools/libxl: Fix build following c/s c3c8da9

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

c/s c3c8da9 "libxl: ao: datacopier callback gets an rc" caused
libxl__domain_save_device_model() to pass its rc directly into the callback.

However in the preexisting code, there were 3 "goto out;" paths which left rc
uninitialised, which is cause by GCC 4.8's -Wmaybe-uninitialized

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CC: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/libxl/libxl_dom.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 600393d..d547eb5 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -2147,7 +2147,7 @@ void libxl__domain_save_device_model(libxl__egc *egc,
     STATE_AO_GC(dss->ao);
     struct stat st;
     uint32_t qemu_state_len;
-    int rc;
+    int rc = -1;
 
     dss->save_dm_callback = callback;
 
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel