Re: [Xen-devel] [RFC PATCH v3 10/18] xen/arm: ITS: Add APIs to add and assign device

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-24 at 12:38 +0100, Julien Grall wrote:
[...]
> > @@ -459,7 +475,7 @@ void its_send_inv(struct its_device *dev, struct 
> > its_collection *col,
> >      its_send_single_command(dev->its, its_build_inv_cmd, &desc);
> >  }
> >  
> > -void its_send_mapd(struct its_device *dev, int valid)
> > +static void its_send_mapd(struct its_device *dev, int valid)
> 
> I would prefer to see this static where the function has been introduced
> and delay the compilation until the end.

Yes, please.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel