Re: [Xen-devel] [PATCH 20/35] libxl: ao abort: Provide public ao abort request API

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jun 26, 2015 at 04:13:59PM +0100, Wei Liu wrote:
> On Fri, Jun 26, 2015 at 04:05:07PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("Re: [PATCH 20/35] libxl: ao abort: Provide public ao abort 
> > request API"):
> > > On Thu, Jun 25, 2015 at 06:44:20PM +0100, Ian Jackson wrote:
> > > [...]
> > > > + * It is possible to abort even an operation which is being performed
> > > > + * synchronously, but since in that case how==NULL you had better only
> > > > + * have one such operation, because it is not possible to tell them
> > > > + * apart.  (And, if you want to do this, obviously the abort would
> > > > + * have to be requested on a different thread.)
> > > > + */
> > ...> 
> > > I interpreted the doc more like "it aborts all sync operations".
> > > 
> > > This function only aborts the first synchronous operation it finds.
> > > The doc didn't make this clear.
> > 
> > I will change it as follows:
> > 
> >    ... you had better only have one such operation, because it is
> >    not possible to tell them apart
> >  + (and libxl_ao_abort will abort only the first one it finds)
> > 
> 
> LGTM
> 

And I should make it clearer:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> > Thanks,
> > Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel