Re: [Xen-devel] [v4][PATCH 13/19] tools/libxc: check to set args.mmio_size before call xc_hvm_build

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jun 26, 2015 at 08:56:50AM +0800, Chen, Tiejun wrote:
> On 2015/6/25 19:08, Wei Liu wrote:
> >On Tue, Jun 23, 2015 at 05:57:24PM +0800, Tiejun Chen wrote:
> >>After commit 5dff8e9eedc7, "libxc/libxl: fill xc_hvm_build_args in
> >>libxl" is introduced, we won't check to set args.mmio_size inside
> >>xc_hvm_build as before. So instead, we need to do this before call
> >>that.
> >>
> >>CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >>CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >>CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >>CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> >>Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> >
> >Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> >Sigh. I missed this because libxl doesn't use this function and there is
> >no in tree xend anymore.
> >
> >I think you should move this earlier in this series. Presumably your RDM
> >changes depend on this.
> >
> 
> Maybe this can be sent out independently since this is more like a fix,
> right?
> 

Yes. That's right. It's not tied to your RDM series.

> Thanks
> Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel