Re: [Xen-devel] [PATCH v2] libxl: Add AHCI support for upstream qemu

[Fabio Fantoni <fabio.fantoni@xxxxxxx>]

Il 25/06/2015 14:18, Ian Campbell ha scritto:
> On Thu, 2015-06-25 at 12:58 +0100, Stefano Stabellini wrote:
> > On Thu, 25 Jun 2015, Fabio Fantoni wrote:
> > > Il 25/06/2015 12:21, Ian Campbell ha scritto:
> > > > On Tue, 2015-06-23 at 11:15 +0200, Fabio Fantoni wrote:
> > > > > Usage:
> > > > > ahci=0|1 (default=0)
> > > > I think a global rather than per disk option is OK (I can't think why a
> > > > user would want to mix and match) but maybe we should consider using an
> > > > enum (with values ide and ahci, defaulting to ide in libxl) so that we
> > > > can add support for whatever fancy new disk controller everyone is using
> > > > in 5 years time?
> > > ahci was added 4 years ago in qemu and I don't know of newer similar
> > > tecnology,
> It maybe hasn't been invented yet (although Malcolm suggested nvme,
> which is plausible).
>
> >   in the case of enum probably shold be more generic for include more
> > > future possibility or I'm wrong? in that case what can be the name?
> > > @stabellini and other developer: any advice about this?
> > I don't know of any other block technologies that would use "hd" as
> > block device names. Virtio-blk uses "vd", so it couldn't be confused.
> > However for the sake of being future proof, it might make sense to
> > introduce an enum, maybe something like "hdtype"?
> >
> > enum hdtype {
> >      ide,
> >      ahci,
> > }
> >
> > then in the config file:
> >
> > hdtype=ahci
> That's the sort of thing I was imagining, yes.
>
> Ian.
Good, I'll do now in v3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel