Re: [Xen-devel] [PATCH OSSTEST v3 02/22] mg-*: Make package fetching common in new mgi-debian

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-24 at 17:00 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v3 02/22] mg-*: Make package fetching 
> common in new mgi-debian"):
> > This pattern appears several times in mg-debian-installer-update and
> > I'm about to add another script which uses it.
> > 
> > The centralised version always does "sort -n -r | head -n" to pick out
> > only the newest version, which only some of the open coded sites did.
> > 
> > Likewise the centralised version checks that $pkgfile is non-empty,
> > unlike some of the open coded sites.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although, another option would be to put this in mgi-common and call
> it "fetch_debian_package".

I'm happy either way, which would you prefer?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel