[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 11/12] x86/altp2m: Add altp2mhvm HVM domain parameter.
>>> On 24.06.15 at 19:57, <edmund.h.white@xxxxxxxxx> wrote: > On 06/24/2015 07:59 AM, Jan Beulich wrote: >>>>> On 22.06.15 at 20:56, <edmund.h.white@xxxxxxxxx> wrote: >>> + case HVM_PARAM_ALTP2MHVM: >>> + if ( a.value > 1 ) >>> + rc = -EINVAL; >>> + if ( a.value && >>> + d->arch.hvm_domain.params[HVM_PARAM_NESTEDHVM] ) >>> + rc = -EINVAL; >>> + break; >> >> As you added the new param to the change-once section of >> hvm_allow_set_param() - what is this code good for? > > I don't understand. How does change-once invalidate this code? The first if of course is needed (to exclude larger values). But afaict the second if() is redundant with the change-once logic, and prevents success from being returned when the tool stack requests a 1->1 change (which is a no-op, and hence ought to be allowed). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |