Re: [Xen-devel] [PATCH v2 11/12] x86/altp2m: Add altp2mhvm HVM domain parameter.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/06/15 18:57, Ed White wrote:
> On 06/24/2015 07:59 AM, Jan Beulich wrote:
>>>>> On 22.06.15 at 20:56, <edmund.h.white@xxxxxxxxx> wrote:
>>> +    case HVM_PARAM_ALTP2MHVM:
>>> +        if ( a.value > 1 )
>>> +            rc = -EINVAL;
>>> +        if ( a.value &&
>>> +             d->arch.hvm_domain.params[HVM_PARAM_NESTEDHVM] )
>>> +            rc = -EINVAL;
>>> +        break;
>> As you added the new param to the change-once section of
>> hvm_allow_set_param() - what is this code good for?
> I don't understand. How does change-once invalidate this code?

I don't believe it does.  This code (appears to) enforce the param being
a boolean, and exclusive against HVM_PARAM_NESTEDHVM.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel