Re: [Xen-devel] [PATCH OSSTEST v3 14/22] Debian: Do not add Debian to UEFI boot order on install

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-24 at 17:11 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v3 14/22] Debian: Do not add Debian to 
> UEFI boot order on install"):
> > By default Debian inserts itself before any existing entries,
> > including the PXE one, meaning we otherwise cannot remotely regroove
> > the box.
> 
> Right.
> 
> > +    if (get_host_property($ho, "firmware") eq "uefi" &&
> > +   $ho->{Suite} =~ m/jessie/) {
> 
> I think you mean
> 
>   +    if (get_host_property($ho, "firmware") eq "uefi")
>   +   die unless $ho->{Suite} =~ m/jessie/;
> 
> or this will expose us to broken boxes beyond jessie.

Ah yes, that's a good idea indeed.

> The rest looks plausible (although a bit unpleasant).

Indeed, hopefully it will be easier in Stretch...




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel