Re: [Xen-devel] [PATCH 7/9] x86/pvh: Handle hypercalls for 32b PVH guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.06.15 at 05:09, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -4959,8 +4979,10 @@ int hvm_do_hypercall(struct cpu_user_regs *regs)
>          return viridian_hypercall(regs);
>  
>      if ( (eax >= NR_hypercalls) ||
> -         (is_pvh_domain(currd) ? !pvh_hypercall64_table[eax]
> -                               : !hvm_hypercall32_table[eax]) )
> +         (is_pvh_vcpu(curr) ? ((mode == 8) ?

Please no switch back to the more expensive is_pvh_vcpu().

> +                               !pvh_hypercall64_table[eax] :
> +                               !pvh_hypercall32_table[eax])
> +                            : !hvm_hypercall32_table[eax]) )

This should be done consistently - either all four variants get
checked, or pvh_hypercall64_table[] simply get replaced by
pvh_hypercall32_table[].

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel