Re: [Xen-devel] [PATCH v3 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.06.15 at 03:40, <wei.w.wang@xxxxxxxxx> wrote:
> Hi Jan,
> On 11/06/2015 16:31, Wei Wang wrote:
>> Add support in the pmstat.c so that the xenpm tool can request to access the
>> intel_pstate driver.
> 
> I want to propose some other changes here to commonize the intel_pstate 
> implementation in this common code (pmstat.c).
>  
> 1) introduce a new struct:
>     struct internal_governor {
>         char *avail_gov;
>         uint32_t cur_gov;         
>         uint32_t gov_num;
>     }
> 
> 2) a new callback in cpufreq_driver, 
> "cpufreq_driver->get_internal_gov(internal_gov)",
>      This allows other possible cpufreq drivers, which implement their own 
> internal governors, to return their own interenal governor info (e.g. we will 
> not need to use the INTEL_PSTATE_GOV_NUM, which is defined to be 4, in this 
> patch).
> 
> Do you think this would be better?

I really need to see this in context.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel