Re: [Xen-devel] [PATCH] xen: add a 'acpi_fake_s3' boot command line parameter

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.06.15 at 13:28, <dario.faggioli@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/acpi/power.c
> +++ b/xen/arch/x86/acpi/power.c
> @@ -33,6 +33,9 @@
>  
>  uint32_t system_reset_counter = 1;
>  
> +static bool_t __read_mostly fake_s3 = 0;
> +boolean_param("acpi_fake_s3", fake_s3);
> +
>  static char __initdata opt_acpi_sleep[20];
>  string_param("acpi_sleep", opt_acpi_sleep);
>  
> @@ -177,7 +180,8 @@ static int enter_state(u32 state)
>      switch ( state )
>      {
>      case ACPI_STATE_S3:
> -        do_suspend_lowlevel();
> +        if ( likely(!fake_s3) )
> +            do_suspend_lowlevel();
>          system_reset_counter++;
>          error = tboot_s3_resume();
>          break;

The change is so simple that, considering it's for debugging purposes
only, I don't see why people needing to debug this code couldn't
apply it themselves when needed. Imo, if to be considered at all, it
should be made !NDEBUG dependent.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel