Re: [Xen-devel] [PATCH OSSTEST v2 19/19] Debian: Arrange to be able to chainload a xen.efi from grub2

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 19/19] Debian: Arrange to be able to 
chainload a xen.efi from grub2"):
> Xen cannot (currently) be booted directly via the usual multiboot
> path on EFI systems of any arch. Instead it is necessary to either
> launch xen.efi direct from the UEFI shell or to chainload it from
> grub. In both cases the Xen command line as well as what would
> normally be the multiboot modules (kernel+command line, XSM policy,
> initrd) must be configured in a Xen configuration file.
> 
> By patching overlay/etc/grub.d/20_linux_xen that if a suitable xen.efi
> is found in the EFI System Partition (as arrange by a previous patch)
> a suitable entry is created in grub.cfg as well.

Urgh.  How horrible.  I don't object to your patch, except that
there's some linewrap or reformatting needed.

> +     if ($need_uefi_chainload) {
> +         die 'chainload entry not found' unless $chainentry;
> +
> +            # Propagate relevant fields of the main entry over to the
> +            # chain entry for use of subsequent code.
> +            foreach (qw(KernVer KernDom0 KernOnly KernOpts Initrd Xenp\
olicy)) {

Wrapping and indentation problems here ?

> +            target_cmd_root($ho,
> +             
> <<END.($entry->{Initrd}?<<END:"").($entry->{Xenpolicy}?<<END:""));
> +                set -ex
> +                cp -vL /boot/$entry->{KernDom0} /boot/efi/EFI/osstest/vml\
inuz #/

It would IMO be better to align the shell at the lhs if there isn't
another way to avoid these overlong lines.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel